[cDAC] Fix stub classification bugs - #131839
Closed
rcj1 wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67f1c1e2-7373-4c6b-8c81-b0442336bcdd
rcj1
requested review from
barosiak,
Copilot,
max-charlamb and
noahfalk
and removed request for
Copilot and
max-charlamb
August 4, 2026 23:25
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
noahfalk
reviewed
Aug 4, 2026
| CDAC_TYPE_FIELD(CodeRangeMapRangeList, T_INT32, RangeListType, cdac_data<CodeRangeMapRangeList>::RangeListType) | ||
| CDAC_TYPE_END(CodeRangeMapRangeList) | ||
|
|
||
| CDAC_TYPE_BEGIN(StubLinkStubManager) |
Member
There was a problem hiding this comment.
We probably need changes in the contract docs describing the new types and how to use them no?
jkotas
reviewed
Aug 5, 2026
| CDAC_TYPE_FIELD(StubLinkStubManager, TYPE(RangeList), RangeList, cdac_data<StubLinkStubManager>::RangeList) | ||
| CDAC_TYPE_END(StubLinkStubManager) | ||
|
|
||
| CDAC_TYPE_BEGIN(RangeList) |
Member
There was a problem hiding this comment.
This rangelist is redundant. We should get rid of all this and unify the stublinker memory management with other types of executable memory.
I have sent copilot to do that https://github.com/dotnet/runtime/tasks/5715a400-48a1-4c09-b6d8-76d2ef2c289b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During internal diagnostics testing, a few discrepancies were found between the native and managed implementations. Specifically, the native implementation gives a name to
StubLinkStubsand not toDynamicHelperstubs.Interpreteris also not a stub, same asJittedandReadyToRun.